Support local variable remapping #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember there being an issue with some obfuscated jars, since they lack a local variable table in the byte code. In that case this remapping would fail. I don't know if it's doable for TR to generate this byte code if any local variable mappings are given? |
|
This pull request is so simple, yet a total lifesaver. Thank you so much for implementing this! 🙏 |
Apparently there's some rudimentary code for LVT generation in Matcher, I'll see if I can repurpose it. That's going to be another PR though, the current changes already work perfectly fine for methods with intact LVT attributes |
modmuss50
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this wasn't enabled yet, from my (arguably limited) testing it looks like everything's working correctly.